Skip to content

Use JuliaFormatter.jl to format all code #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

metab0t
Copy link
Collaborator

@metab0t metab0t commented Jun 10, 2022

No description provided.

@andyferris
Copy link

I like where this series of PRs is going. Is there any holdup or blocker here?

@metab0t
Copy link
Collaborator Author

metab0t commented Aug 1, 2022

Pinging @quinnj.
Would you like to review this?
Diff of further refactoring will be nicer based on this PR.

@quinnj quinnj closed this Aug 30, 2022
@quinnj quinnj reopened this Aug 30, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #297 (392d3a9) into master (c1ede93) will decrease coverage by 0.11%.
The diff coverage is 77.72%.

@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
- Coverage   85.99%   85.88%   -0.12%     
==========================================
  Files           5        5              
  Lines         707      758      +51     
==========================================
+ Hits          608      651      +43     
- Misses         99      107       +8     
Impacted Files Coverage Δ
src/consts.jl 88.88% <ø> (ø)
src/api.jl 57.40% <55.00%> (+0.26%) ⬆️
src/SQLite.jl 94.05% <86.00%> (-2.08%) ⬇️
src/UDF.jl 86.15% <95.23%> (+0.10%) ⬆️
src/tables.jl 99.35% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@quinnj
Copy link
Member

quinnj commented Aug 30, 2022

Sorry for the delay here; this is great!

@quinnj quinnj merged commit a4e4da3 into JuliaDatabases:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants