Report the failing INSERT when load!() errors
#277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQLite3 provides `sqlite3_expanded_sql()` to retrieve the _as-bound_ statement text; this makes it possible to report the exact failing INSERT when `load!()` fails, e.g. due to a `PRIMARY KEY` violation.
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
==========================================
+ Coverage 85.46% 85.87% +0.41%
==========================================
Files 5 5
Lines 688 701 +13
==========================================
+ Hits 588 602 +14
+ Misses 100 99 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLite3 provides
sqlite3_expanded_sql()to retrieve the as-bound statement text; this makes it possible to report the exact failing INSERT whenload!()fails, e.g. due to aPRIMARY KEYviolation.I found it very useful when debugging all the various ways a pre-existing data source violated its own nominal schema.