Skip to content

Convert NULL type columns to Julia Missing type #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Convert NULL type columns to Julia Missing type #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/SQLite.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,7 @@ juliatype(x::Integer) =
x == SQLITE_INTEGER ? Int64 :
x == SQLITE_FLOAT ? Float64 :
x == SQLITE_TEXT ? String :
x == SQLITE_NULL ? Missing :
Any

# convert SQLite declared type into Julia equivalent,
Expand Down
2 changes: 1 addition & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ end
empty_tbl = DBInterface.execute(columntable, db, "SELECT * FROM Employee WHERE FirstName='Joanne'")
all_tbl = DBInterface.execute(columntable, db, "SELECT * FROM Employee")
@test propertynames(empty_tbl) == propertynames(all_tbl)
@test all(col -> eltype(empty_tbl[col]) >: eltype(all_tbl[col]), propertynames(all_tbl))
@test all(col -> eltype(empty_tbl[col]) == Missing || eltype(empty_tbl[col]) >: eltype(all_tbl[col]), propertynames(all_tbl))
end

DBInterface.execute(db, "create table temp as select * from album")
Expand Down