Add levels #12
Merged
Add levels #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently lives in Missings.jl, which isn't the most logical place. This will allow StatsModels to drop the dependency on Missings, while CategoricalArrays will continue adding a specialized method to it.
bkamins
reviewed
Oct 2, 2019
bkamins
approved these changes
Oct 2, 2019
quinnj
approved these changes
Oct 2, 2019
nalimilan
added a commit
to JuliaData/Missings.jl
that referenced
this pull request
Oct 3, 2019
Keep exporting it for now: if we added a deprecation, it would be triggered even when people call levels after loading CategoricalArrays or DataFrames. Depends on JuliaData/DataAPI.jl#12.
nalimilan
added a commit
to JuliaData/Missings.jl
that referenced
this pull request
Oct 3, 2019
Keep exporting it for now: if we added a deprecation, it would be triggered even when people call levels after loading CategoricalArrays or DataFrames. Depends on JuliaData/DataAPI.jl#12.
nalimilan
added a commit
to JuliaData/Missings.jl
that referenced
this pull request
Oct 3, 2019
Keep exporting it for now: if we added a deprecation, it would be triggered even when people call levels after loading CategoricalArrays or DataFrames. Depends on JuliaData/DataAPI.jl#12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently lives in Missings.jl, which isn't the most logical place. This will allow StatsModels to drop the dependency on Missings, while CategoricalArrays will continue adding a specialized method to it.
For reference about the behavior of
levels, see discussion at JuliaLang/julia#20800.Cc: @kleinschmidt