Fix eltype in empty static array construction #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyferris
reviewed
Aug 25, 2019
|
|
||
| @inline _convert(SA, a, ::Length{L}) where L = SA(unroll_tuple(a, Length(SA))) | ||
| @inline _convert(SA, a, l::Length) = SA(unroll_tuple(a, l)) | ||
| @inline _convert(SA::Type{<:StaticArray{<:Tuple,T}}, a, ::Length{0}) where T = similar_type(SA, T)(()) |
There was a problem hiding this comment.
I suspect a type assertion would be good here (that the output is indeeed an SA).
There was a problem hiding this comment.
We could do that. Which error condition are you trying to cover, is it protection for the user to avoid stack overflows when they have a broken similar_type (constructor calling _convert calling constructor etc) or some such?
There was a problem hiding this comment.
Just guarding against the case that similar_type(SA) isn’t an SA (like rotations) which means constructors and conversion might return a rather surprising result.
c42f
added a commit
that referenced
this pull request
Oct 16, 2019
c42f
added a commit
that referenced
this pull request
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #651