Change SOneTo indexing and support \ for svd(M; full=true) #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oddly, the MacOS build for julia-1.0 failed with a timeout. There wasn't a lot to see in the build log so I've restarted it. |
c42f
approved these changes
Jun 11, 2019
| @test m[:, 1:2] isa Matrix | ||
| @test m[:, [true, false, false]] isa Matrix | ||
| @test m[:, SOneTo(2)] isa MMatrix{2, 2, Int} | ||
| @test m[:, SOneTo(2)] isa SMatrix{2, 2, Int} |
There was a problem hiding this comment.
I think this new behavior is preferable because it's more consistent. It's technically breaking, but I think the chances of this breaking the average user of StaticArrays are low.
|
|
||
| # SOneTo | ||
| @testinf sm[SOneTo(1),:] === @SMatrix [1 3] | ||
| @testinf sm[:,SOneTo(1)] === @SMatrix [1;2] |
There was a problem hiding this comment.
Could you add an equivalent test for MMatrix just to assert the MMatrix type is preserved?
[edit - I went ahead and added this]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#613 didn't have adequate test coverage for solving problems like
svd(A) \ vwhenAis non-square. It worked for the "thin" decomposition, butsvd(A; full=Val(true)) \ vfailed.While implementing this I noticed what appeared to be missing support for indexing StaticArrays with
SOneTo. This led to a change in one test result (see bea22b4), so this is worth thinking about carefully and is a breaking change.