Adopt examples in README to current Julia version #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have noticed, that some of the code examples in the `Quick start` section of the README don't work because they were designed for an older version of Julia. This PR modifies these examples to make them work with Julia v1.1.1.
andyferris
approved these changes
Jun 3, 2019
README.md
Outdated
| # Is (partially) hooked into BLAS, LAPACK, etc: | ||
| rand(MMatrix{20,20}) * rand(MMatrix{20,20}) # large matrices can use BLAS | ||
| eig(m3) # eig(), etc uses specialized algorithms up to 3×3, or else LAPACK | ||
| eigvecs(m3) # eigvecs(), etc uses specialized algorithms up to 3×3, or else LAPACK |
There was a problem hiding this comment.
FYI the equivalent thing is eigen. (It probably doesn't matter).
There was a problem hiding this comment.
Ah, I didn't find this, I only found eigvecs and eigvals. I will change it to eigen.
|
Let me know If I need to change anything else. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed, that some of the code examples in the
Quick startsection of the README don't work because they were designed for an older version of Julia. This PR modifies these examples to make them work with Julia v1.1.1.