Skip to content

Allow using static arrays as index for views #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2019
Merged

Allow using static arrays as index for views #586

merged 1 commit into from
Mar 11, 2019
+14 −0

Conversation

tribut
Copy link
Contributor

@tribut tribut commented Jan 18, 2019

The PR allows using static arras as index when using views, such as

a = [10,20,30,40]
idx = SVector(2,4)
b = view(a, idx)

@tribut tribut force-pushed the general-indexing-checkbounds branch from 49c8fc1 to a33080d Compare January 18, 2019 09:28
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 66.0% when pulling a33080d on tribut:general-indexing-checkbounds into 786b6f0 on JuliaArrays:master.

@tribut tribut mentioned this pull request Mar 11, 2019
Closed
@andyferris andyferris merged commit 2c8d82f into JuliaArrays:master Mar 11, 2019
@andyferris
Copy link
Member

Thanks - and sorry for the two month delay, @tribut!

@c42f c42f mentioned this pull request Jun 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyferris andyferris andyferris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tribut @coveralls @andyferris