overload Base.setindex #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I think CI fail is unrelated. |
andyferris
approved these changes
Feb 25, 2018
tkf
added a commit
to tkf/Setfield.jl
that referenced
this pull request
Jun 11, 2018
It's included in StaticArrays v0.7.0: JuliaArrays/StaticArrays.jl#370
jw3126
pushed a commit
to jw3126/Setfield.jl
that referenced
this pull request
Jun 13, 2018
* Remove StaticArrays.setindex hack It's included in StaticArrays v0.7.0: JuliaArrays/StaticArrays.jl#370 * Skip test_quicktypes.jl in 0.7 * Use __module__ in Julia 0.7 * "using Test" in Julia 0.7 * Fix deprecated warnings in test_core.jl * Clarify broken tests due to dot-call syntax * Simplify settable macro
aplavin
pushed a commit
to aplavin/Accessors.jl
that referenced
this pull request
Jun 8, 2022
* Remove StaticArrays.setindex hack It's included in StaticArrays v0.7.0: JuliaArrays/StaticArrays.jl#370 * Skip test_quicktypes.jl in 0.7 * Use __module__ in Julia 0.7 * "using Test" in Julia 0.7 * Fix deprecated warnings in test_core.jl * Clarify broken tests due to dot-call syntax * Simplify settable macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already a
setindexfunction inBase, we should overload it.It would allow to remove this hack.