Workaround inference problem in round.(Int,v) #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julia-0.6 doesn't seem to do constant propagation of `Type`s in quite the way which would be required to get good efficiency for broadcasting `round`. Insert a minimal workaround for this particularly common case.
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
==========================================
+ Coverage 93.13% 93.14% +<.01%
==========================================
Files 37 37
Lines 2653 2654 +1
==========================================
+ Hits 2471 2472 +1
Misses 182 182
Continue to review full report at Codecov.
|
|
I'm going to just merge this as it's a minimal fix. We can decide what to do about #330 later :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the same problem as #330 but in a more minimal way. Fixes #329 .
julia-0.6 doesn't seem to do constant propagation of
Types in quitethe way which would be required to get good efficiency for broadcasting
round.Insert a minimal workaround for this particularly common case.