Remove some uses of @pure
#1253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+48
to
+50
| @generated function triangularroot(::Val{L}) where {L} | ||
| return div(isqrt(8 * L + 1) - 1, 2) # from quadratic formula | ||
| end |
There was a problem hiding this comment.
Does this have to be a @generated function with a Val argument? To me it looks like constant propagation works like a charm for plain
triangularroot(L::Int) = div(isqrt(8 * L + 1) - 1, 2)There was a problem hiding this comment.
It's hard to tell for me how it would interact with inlining if it were a normal function. We can always change it in a later PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it will be much easier to track potential performance regressions when pure removal is split into a few steps. This is the first one.