Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Jan 18, 2021

The inner OffsetArray constructor requires the offsets to be Ints, and #188 allowed other Integer types to be converted to Ints. This PR adds a type assertion in the outer constructor to avoid a stack overflow if the conversion doesn't work as expected.

@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #191 (6577f3f) into master (e65fd01) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   99.28%   99.28%           
=======================================
  Files           5        5           
  Lines         280      280           
=======================================
  Hits          278      278           
  Misses          2        2           
Impacted Files Coverage Δ
src/OffsetArrays.jl 98.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e65fd01...6577f3f. Read the comment docs.

@jishnub jishnub merged commit b20b4db into JuliaArrays:master Jan 18, 2021
@jishnub jishnub deleted the typeassert branch January 18, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants