Make indexing idempotent again #156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patchwork of fixes that address a couple of common cases encountered while indexing with offset axes.
Now
This is not really a proper fix, as ideally we would want to return an
OffsetVectorwhen anOffsetRangeis indexed using an arbitraryAbstractUnitRange. However that might be too breaking, so as of now I suppose this will have to do.Fixes #155