add offset overflow check

[johnnychen94]

Although this is related to overflow behavior in IdOffsetRange, the better place to raise an error is at the construction time of OffsetArray.

julia> a = rand(10);

julia> ao = OffsetArray(a, typemax(Int)-1)
ERROR: ArgumentError: Boundary overflow detected: offset 9223372036854775806 should be smaller than 9223372036854775797

Performance overhead should be acceptable:

a = zeros(5,5,5,5);

# Before: 14.129 ns (0 allocations: 0 bytes)
@btime OffsetArray($a, -2:2, -2:2, -2:2, -2:2);

# After: 15.952 ns (0 allocations: 0 bytes)
@btime OffsetArray($a, -2:2, -2:2, -2:2, -2:2);

closes #136

[codecov]

Codecov Report

Merging #144 into master will increase coverage by 1.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   91.39%   92.64%   +1.25%     
==========================================
  Files           2        2              
  Lines         244      272      +28     
==========================================
+ Hits          223      252      +29     
+ Misses         21       20       -1     

Impacted Files	Coverage Δ
src/OffsetArrays.jl	92.98% <100.00%> (+1.48%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55af8ad...967873f. Read the comment docs.

[stevengj]

Why define a function for this?

[jishnub]

It appears to improve the performance, not entirely sure why

[johnnychen94]

I opened a new issue in JuliaLang/julia#37558

In this PR I just switched back to the simple version and don't tweak it; IMO 5-10ns difference isn't critical to our use case.