-
Notifications
You must be signed in to change notification settings - Fork 16
Support Julia 1.12 #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
==========================================
- Coverage 85.60% 78.94% -6.66%
==========================================
Files 1 1
Lines 132 152 +20
==========================================
+ Hits 113 120 +7
- Misses 19 32 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I do not think there is a good way to get nice output for closures with Julia 1.12. The closures themselves are more complex, they contains type checks etc., and reconstituting @timholy CI should now be working – can you approve running the CI workflow? |
|
Ping – can you approve the CI workflow? |
|
Ping |
|
Can you run the CI? |
timholy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay; to any other JuliaLinearAlgebra folks, feel free to merge this once a decision has been made on the naming of the anonymous function in the test. (I'm OK with whatever.)
test/runtests.jl
Outdated
| c = mappedarray(sqrt, x->x*x, a) | ||
| @test summary(c) == "4-element mappedarray(sqrt, x->x * x, ::$(Vector{Int})) with eltype Float64" | ||
| if VERSION >= v"1.12.0" | ||
| @test summary(c) == "4-element mappedarray(sqrt, var\"#21#22\"(), ::$(Vector{Int})) with eltype Float64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var\"#21#22\" seems like it could be fragile in a test; what if we modify the package so it creates additional gensyms?
Likewise below
Closes #64