Skip to content

Conversation

@eschnett
Copy link

Closes #64

@timholy timholy closed this Oct 23, 2025
@timholy timholy reopened this Oct 23, 2025
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 65.11628% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.94%. Comparing base (7c34681) to head (846a6c7).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/MappedArrays.jl 65.11% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   85.60%   78.94%   -6.66%     
==========================================
  Files           1        1              
  Lines         132      152      +20     
==========================================
+ Hits          113      120       +7     
- Misses         19       32      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eschnett
Copy link
Author

I do not think there is a good way to get nice output for closures with Julia 1.12. The closures themselves are more complex, they contains type checks etc., and reconstituting x -> x*x would now be a major effort. If we wanted this then we should probably use an external package for this, or maybe modify Julia itself to keep a pretty-printable syntax tree around.

@timholy CI should now be working – can you approve running the CI workflow?

@eschnett
Copy link
Author

Ping – can you approve the CI workflow?

@eschnett
Copy link
Author

eschnett commented Nov 4, 2025

Ping

@eschnett
Copy link
Author

eschnett commented Nov 6, 2025

Can you run the CI?

Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay; to any other JuliaLinearAlgebra folks, feel free to merge this once a decision has been made on the naming of the anonymous function in the test. (I'm OK with whatever.)

test/runtests.jl Outdated
c = mappedarray(sqrt, x->x*x, a)
@test summary(c) == "4-element mappedarray(sqrt, x->x * x, ::$(Vector{Int})) with eltype Float64"
if VERSION >= v"1.12.0"
@test summary(c) == "4-element mappedarray(sqrt, var\"#21#22\"(), ::$(Vector{Int})) with eltype Float64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var\"#21#22\" seems like it could be fragile in a test; what if we modify the package so it creates additional gensyms?

Likewise below

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken on v1.12

2 participants