depend on Collects.jl, excise collect_as
#123
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
- Coverage 96.71% 94.27% -2.45%
==========================================
Files 5 5
Lines 274 227 -47
==========================================
- Hits 265 214 -51
- Misses 9 13 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nsajko
force-pushed
the
excise_collect_as
branch
3 times, most recently
from
4f1a0f5 to
5a1002a
Compare
nsajko
changed the title
collect_ascollect_as
This comment was marked as outdated.
This comment was marked as outdated.
nsajko
force-pushed
the
excise_collect_as
branch
3 times, most recently
from
5e362b8 to
25fa738
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
The vector -> matrix conversion (or any other M -> N with N =! 1) would be ambiguous, I'm not entirely sure allowing only the X -> vector conversion is worthwhile (especially since |
|
OK, will make it throw. EDIT: done. |
| end | ||
| function push!!(::Type{<:AbstractVector}, v::Vector, e) | ||
| push(v, e) | ||
| function infer_ndims_impl(::Base.IteratorSize) |
There was a problem hiding this comment.
Is there an easy test to exercise this function?
There was a problem hiding this comment.
It's already exercised (checked by replacing 1 with error("exercised!")). This is just this issue again:
2 participants
Fixes #81