-
Notifications
You must be signed in to change notification settings - Fork 39
Set julia compat to v1.10 #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #397 +/- ##
==========================================
- Coverage 99.91% 99.48% -0.44%
==========================================
Files 8 8
Lines 1147 1154 +7
==========================================
+ Hits 1146 1148 +2
- Misses 1 6 +5 ☔ View full report in Codecov by Sentry. |
I think it would be a good opportunity to also clean up existing |
It actually seems that Julia < 1.10.10 is completely untested at this point: FillArrays.jl/.github/workflows/ci.yml Lines 40 to 43 in f160c66
min as well (which currently would be 1.6.0 and with this PR 1.10.0 , in contrast to lts which is 1.10.10 ).
|
I think testing |
In principle, you don't have to fix anything apart from correcting the Julia compat entry: If the package does not support 1.10.0, it should not be declared to be compatible with 1.10.0. Currently, the problem is even more sever as not testing |
I agree that in theory we should be testing v1.6.x right now. But one can argue if a version of Julia is no longer supported then there shouldn't be an expectation that packages continue to work I'm less worried about CI time than I am additional developer burden. Every extra test is an extra point of failure... |
Since v1.10 is the LTS now, we may focus development only on v1.10+. Versions of this pacakge <v1.15 would continue to be compatible with julia v1.6.