Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Jul 25, 2023

After this,

julia> convert(Zeros{Float64}, Fill(0,2))
2-element Zeros{Float64}

julia> convert(Zeros, Fill(0,2))
2-element Zeros{Int64}

julia> convert(Ones, Fill(0,2))
ERROR: ArgumentError: cannot convert an array containinig 0 to Ones

This PR addresses #282 (comment)

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #284 (30675b5) into master (41715aa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #284   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files           5        5           
  Lines         851      863   +12     
=======================================
+ Hits          850      862   +12     
  Misses          1        1           
Files Changed Coverage Δ
src/FillArrays.jl 99.74% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dlfivefifty dlfivefifty merged commit 1efbdbb into JuliaArrays:master Jul 26, 2023
@jishnub jishnub deleted the convertzerosones branch July 26, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants