-
Notifications
You must be signed in to change notification settings - Fork 33
Incorporate blocks into axis, support offset blocks #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
- Coverage 80.69% 80.43% -0.26%
==========================================
Files 12 10 -2
Lines 637 639 +2
==========================================
Hits 514 514
- Misses 123 125 +2
Continue to review full report at Codecov.
|
The tests are passing (at least locally) so it would be nice to get a review. @tkf would you be able to do this? I still need to update the docs before this gets merges. This PR changes it so block sizes are incorporated into directly into the axis. This means instead of a single type Another benefit is that we get free support for offset block indexing using OffsetArrays.jl. This was mostly done for "fun" (or rather, as an excuse to merge this PR), though there are cases where this will be useful. In my basic performance tests there is negligible performance change; e.g., @KristofferC If you are still using this package, do you have any opinions? EDIT: I think I ran the tests in the wrong window so still need to make some fixes to get broadcasting working. |
Sorry, I can't review this ATM, at least until this weekend. |
No worries, no rush on my end. |
@tkf The tests are now passing if you find time to have a look. |
Still don't have time to review this in detail (BTW, please don't wait for me if this is a blocker), but...
This is really cool! I suppose another advantage is that it works for statically-encoded |
I looked at broadcasted code and it LGTM. |
Co-Authored-By: Takafumi Arakaki <[email protected]>
This redesign when complete should resolve #26, #59, #91, and also support offset block ranges.