feat(reaclette): Reset state by effect test #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-f
reviewed
Mar 15, 2019
src/new.spec.js
Outdated
| effects: { | ||
| async foo() { | ||
| this.state.qux = "baz"; | ||
| this.resetState(); |
julien-f
reviewed
Mar 15, 2019
src/new.spec.js
Outdated
| }, | ||
| }); | ||
| return effects.foo(); | ||
| }); |
There was a problem hiding this comment.
Merge with context test.
julien-f
reviewed
Mar 15, 2019
src/new.spec.js
Outdated
| expect(ownProps(this.effects)).toEqual(["myEffect", "_setState"]); | ||
|
|
||
| expect(typeof this.resetState).toBe("function"); | ||
| this.state.myEntry = "thud"; |
There was a problem hiding this comment.
It is necessary to test the state before resetState!
You can move this after the state tests below.
julien-f
reviewed
Mar 15, 2019
src/new.spec.js
Outdated
| this.state.myEntry = "baz"; | ||
| expect(this.state.myEntry).toBe("baz"); | ||
|
|
||
| expect(typeof this.resetState).toBe("function"); |
There was a problem hiding this comment.
This is unnecessary because you are already calling it.
julien-f
reviewed
Mar 15, 2019
src/new.spec.js
Outdated
| expect(this.state.myEntry).toBe("baz"); | ||
|
|
||
| expect(typeof this.resetState).toBe("function"); | ||
| this.state.myEntry = "thud"; |
There was a problem hiding this comment.
What's the point of this if it has already been changed to baz?
julien-f
approved these changes
Mar 15, 2019
julien-f
pushed a commit
that referenced
this pull request
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.