Support -Xwarning-level for Opt-in CLI diagnostics
#5568
+159
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oCompilerMessageSeverity` It allows using the function in `BaseDiagnosticsCollector` (for FIR CLI diagnostics) and refines the code
…brains.kotlin.fir.analysis.diagnostics` To make it possible to use them in FIR CLI checkers Also, now they live in a package where regular `FirErrors` live
It required changing of `getEffectiveSeverity` visibility to public Simplify code of `CompilerConfiguration.reportIfNeeded`
…nfigured using `-Xwarning-level` ^KT-48419 Fixed
KvanTTT
commented
Nov 18, 2025
Comment on lines
+23
to
+27
| val CLI_COMPILER_PLUGIN_IS_EXPERIMENTAL: KtSourcelessDiagnosticFactory by warningWithoutSource() | ||
| val CLI_OPT_IN_REQUIREMENT_MARKER_IS_UNRESOLVED: KtSourcelessDiagnosticFactory by warningWithoutSource() | ||
| val CLI_NOT_AN_OPT_IN_REQUIREMENT_MARKER: KtSourcelessDiagnosticFactory by warningWithoutSource() | ||
| val CLI_OPT_IN_REQUIREMENT_MARKER_IS_DEPRECATED: KtSourcelessDiagnosticFactory by warningWithoutSource() | ||
| val CLI_OPT_IN_REQUIREMENT_MARKER_IS_DEPRECATED_ERROR: KtSourcelessDiagnosticFactory by errorWithoutSource() |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if CLI_ prefixes are needed here. It probably makes sense to remove them.
Contributor
Author
|
@copilot why can't you review the pull request? Which error did you encounter? |
Contributor
Author
|
@copilot I didn't ask you to do what you've done, but answer the question that I asked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://youtrack.jetbrains.com/issue/KT-48419/Using-a-RequiresOptIn-API-that-does-not-exist-should-have-an-option-to-not-output-a-warning
I've prepared the PR on GitHub to test GitHub Copilot code review.