Initial support for Swift export #723
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbogolepov
force-pushed
the
swift-export-v1
branch
from
0641af2 to
9a58408
Compare
nikpachoo
approved these changes
May 17, 2024
nikpachoo
force-pushed
the
swift-export-v1
branch
from
21f01d3 to
a49ae3d
Compare
Collaborator
|
DO NOT MERGE IT. |
Collaborator
|
A note for the devs: in prod, we use "swift-export-v1" branch |
mMaxy
reviewed
Jun 3, 2024
| SirAsSwiftSourcesPrinter.print( | ||
| sirModule, | ||
| stableDeclarationsOrder = true, | ||
| renderDocComments = true, |
There was a problem hiding this comment.
This should be false - we do not support them currently, see KT-68744 for more information.
Contributor
|
Are there any updates? |
sbogolepov
force-pushed
the
swift-export-v1
branch
from
9dbe660 to
acd57be
Compare
Collaborator
|
@sbogolepov, could you please rebase you changes on the master? |
Minor hack: use wasm stdlib to avoid downloading the whole K/N distribution
sbogolepov
force-pushed
the
swift-export-v1
branch
from
acd57be to
39e8501
Compare
Collaborator
Author
|
Sure, done. Now that we have a proper publishing of Swift export artifacts the dependency hell is gone, and everything looks more or less clean. |
Collaborator
|
The task https://youtrack.jetbrains.com/issue/KTL-2801 assumes closing this MR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes:
build.gradle.kts.There might be bugs. We will squash them as soon as possible :)