Skip to content

Conversation

@jasonlessenich
Copy link
Member

@jasonlessenich jasonlessenich commented Jul 23, 2022

Closes #259

This PR introduces /move-conversation, which makes it easier for users to easily move conversations to other channels by clicking the links the bot provides. It is highly inspired by the Rust Community Discord, where this works quite well.

image
image

@jasonlessenich jasonlessenich added enhancement Improvement of an already existing feature review requested new feature labels Jul 23, 2022
@jasonlessenich jasonlessenich self-assigned this Jul 23, 2022
@jasonlessenich jasonlessenich requested a review from a team as a code owner July 23, 2022 23:09
Copy link
Member

@danthe1st danthe1st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who is allowed to move channels? There neither seem to be any permission check (staff and maybe certified helpers if the conversation is moved to a help channel) nor a voting system (not sure whether a voting system is a good idea).

Aside from that, where is the command descriptor?

@MoonTM-GIT
Copy link
Member

I feel like we dont need to restrict this command, but I would change the text to make it clear it's a suggestion (for example just suggested_ instead of requested)

@danthe1st
Copy link
Member

danthe1st commented Jul 24, 2022

If it's just about suggesting to move a conversation, what's the point of having a command for that over just mentioning it in the chat?
Furthermore, if this is kept as-is, the command name should reflect that. /move-conversation doesn't seem like suggesting it.

@MoonTM-GIT
Copy link
Member

If it's just about suggesting to move a conversation, what's the point of having a command for that over just mentioning it in the chat?

To make it easier, just like tags/custom commands

@MoonTM-GIT
Copy link
Member

And making clear it's a suggestion could just be done in the command description

@danthe1st
Copy link
Member

Most people don't read the command description. The title /move-conversation strongly suggests that the command is actually about moving the conversation, not about suggesting to do so.

@MoonTM-GIT
Copy link
Member

MoonTM-GIT commented Jul 24, 2022

It's obvious nobody has the ability to force someone to go somewhere else, and even if they do they'll see once they have used the command as the text clearly says suggested

At least in my opinion

@danthe1st
Copy link
Member

danthe1st commented Jul 24, 2022

I am talking about people that use the command (also for the first time), not other people seeing the message. The name /move-conversation looks like it is a restricted command discouraging its use for normal usets.

@jasonlessenich
Copy link
Member Author

jasonlessenich commented Jul 24, 2022

I think the name is quite fitting. Do you have a better one?

@jasonlessenich
Copy link
Member Author

thanks liquid

@liquiddevelopmentnet
Copy link
Member

thanks liquid

You're welcome json

@jasonlessenich
Copy link
Member Author

@danthe1st can this be merged?

@MoonTM-GIT MoonTM-GIT merged commit 9c67cde into dynxsty/dih4jda Jul 25, 2022
@MoonTM-GIT MoonTM-GIT deleted the dynxsty/move_conversation branch July 25, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement of an already existing feature new feature review requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a /move-conversation feature, inspired by the Rust Community Discord

5 participants