-
Notifications
You must be signed in to change notification settings - Fork 24
Move Conversation #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Conversation #318
Conversation
danthe1st
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who is allowed to move channels? There neither seem to be any permission check (staff and maybe certified helpers if the conversation is moved to a help channel) nor a voting system (not sure whether a voting system is a good idea).
Aside from that, where is the command descriptor?
|
I feel like we dont need to restrict this command, but I would change the text to make it clear it's a suggestion (for example just suggested_ instead of requested) |
|
If it's just about suggesting to move a conversation, what's the point of having a command for that over just mentioning it in the chat? |
To make it easier, just like tags/custom commands |
|
And making clear it's a suggestion could just be done in the command description |
|
Most people don't read the command description. The title |
|
It's obvious nobody has the ability to force someone to go somewhere else, and even if they do they'll see once they have used the command as the text clearly says suggested At least in my opinion |
|
I am talking about people that use the command (also for the first time), not other people seeing the message. The name |
|
I think the name is quite fitting. Do you have a better one? |
…h gets sent to the current channel does not have to wait for the link
src/main/java/net/javadiscord/javabot/systems/user_commands/MoveConversationCommand.java
Show resolved
Hide resolved
|
thanks liquid |
You're welcome json |
|
@danthe1st can this be merged? |
Closes #259
This PR introduces
/move-conversation, which makes it easier for users to easily move conversations to other channels by clicking the links the bot provides. It is highly inspired by the Rust Community Discord, where this works quite well.