Skip to content

Fix client not reloading on hash mismatch #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Fix client not reloading on hash mismatch #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/py/reactpy/reactpy/core/serve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,20 +191,20 @@ async def _do_state_rebuild_for_reconnection(self, layout: Layout) -> str:
client_state = serializer.deserialize_client_state(state_vars)
layout.reconnecting.set_current(True)
layout.client_state = client_state
except StateRecoveryFailureError:
logger.exception("State recovery failed")
layout.reconnecting.set_current(False)
layout.client_state = {}
else:

salt = client_state_msg["salt"]
try:
layout.start_rendering_for_reconnect()
await layout.render_until_queue_empty()
except StateRecoveryFailureError:
logger.warning("Client state non-recoverable. Starting fresh")
logger.warning(
"State recovery failed (likely client from different version). Starting fresh"
)
await layout.finish()
layout.reconnecting.set_current(False)
layout.client_state = {}
await layout.start()
layout.start_rendering()
return salt
layout.reconnecting.set_current(False)
layout.client_state = {}
return salt