Skip to content

Conversation

@Nisgrak
Copy link

@Nisgrak Nisgrak commented Jan 26, 2024

Fix the type of the result in the items sections, specially in readItems

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Before:
image
After:
image

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@vercel
Copy link

vercel bot commented Jan 26, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @Intevel on Vercel.

@Intevel first needs to authorize it.

@Nisgrak
Copy link
Author

Nisgrak commented Jan 26, 2024

Thanks for the migration to the new sdk! If you need more help with some areas please let me know, I will love to help.

@casualmatt
Copy link
Collaborator

LGTM.

Ty for the fix; the module is pretty much finished; I'm stress-testing it with auth, SSR, SSG, and many runtime engines.
The best would be to use it and test it as much as possible.

@casualmatt casualmatt merged commit 84ef6cd into Intevel:dev Jan 27, 2024
@sandros94
Copy link
Collaborator

I remember adding the any type just for an old type error I was getting during the initial rewrite.

Once I get home in a couple of days I'll check if indeed those were solved. If they are I'll remove all the other any from the remaining read* function types that use useAsyncData

@Nisgrak Nisgrak deleted the dev branch February 3, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants