Skip to content

Conversation

@rmkaplan
Copy link
Contributor

@rmkaplan rmkaplan commented Sep 9, 2025

Addresses #2281.

The files should close on internal errors, and no textstream will be returned.

Copy link
Contributor

@pamoroso pamoroso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR on Linux Mint 22.1 Cinnamon and confirm it resolves issue #2281 as described there.

Copy link
Member

@fghalasz fghalasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ran doHCFiles.yml in Github Actions as well as do_hcfiles.sh on Ubuntu 24.04 on WSL2. All runs completed successfully. Tests showed no extraneous open files during the runs.

@pamoroso
Copy link
Contributor

HCFILES now runs to completion but the formatting of the produced prettyprinted Lisp files looks off. For example, there's too much bold text.

@rmkaplan
Copy link
Contributor Author

rmkaplan commented Sep 11, 2025 via email

@pamoroso
Copy link
Contributor

It's generally true, it happens with all Lisp files. TEdit files look fine though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants