Workaround added to (HCFILES) to close TEDIT files left open after breaks in OPENTEXTSTREAM. Temporary fix for HCFiles github action. #2282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs in OPENTEXTSREAM cause premature exit without properly closing the underlying open file stream. This works around failures in HCFILES, especially when run in github actions. Will remove this workaround when bug is fixed in OPENTEXTSTREAM.
|
Closing unmerged since PR#2284 fixes the HCFILES problem by fixing the root cause. Hence this workaround is no longer necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENTEXTSTREAM has a bug whereby which the underlying file stream is left open after a break occurs while reading a TEdit file. In addition, Maiko has some serious deficiencies in its handling of Unix Shell commands. Together these bugs are causing HCFILES to fail without notice in github actions.
Fixing OPENTEXTSTREAM and Maiko is the proper solution But these fixes are way beyond my comfort level. Issues have been (will be) created for these two bug separately.
Meanwhile, this PR creates a workaround in (HCFILES) that closes the errant open files after an error return from OPENTEXTSTREAM. This allows the RunHCFILES.yml github action to run successfully.
A run made using this fix is already up at files.interlisp.org.