Consolidated files to SFC, improved naming conventions #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi and thank you for the contribution that i will soon probably merge, and sorry for the late response. i havent found the time yet to do a quick check, only thing that comes to mind is that the original version was built as separate files instead of SFC so that no Webpack/Build-Tool environment is needed and it can be used anywhere right away. i may replace the current code with the SFC |
|
No rush. I converted it to an SFC because I'll be using the SFC version in my application and felt like I should share. Using Vue without a build tool would be a crazy hindrance and I couldn't imagine not adding one haha. You don't have to replace the old one, but the SFC will be most Vue user's preference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ES6 conversion, Vue SFC, changed naming conventions to be more clear, vuified some things that were vanilla js