Skip to content

Conversation

@zyxkad
Copy link
Collaborator

@zyxkad zyxkad commented Mar 17, 2025

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • Docs have been added / updated (for features or maybe bugs which were noted). If not, please update the needed documentation here. Feel free to remove this check if you don't need it
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)
    Feature

  • What is the new behavior (if this is a feature change)?
    People can invoke [export|import][Item|Fluid] on other bridge peripherals, or invoke [pull|push][Item|Fluid] on bridges from normal inventories.

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
    The default item filter count changed from 64 to infinity (max integer)
    The default fluid filter count changed from 1000 to infinity (max integer)

  • Other information:

@zyxkad zyxkad requested a review from SirEndii March 17, 2025 21:05
@SirEndii
Copy link
Member

The default filter count changed from 64 to infinity (max integer)

Why and shouldn't we also do that for the fluid filter then?

@zyxkad
Copy link
Collaborator Author

zyxkad commented Mar 17, 2025

The default filter count changed from 64 to infinity (max integer)

Why and shouldn't we also do that for the fluid filter then?

Yes I just forgot that

@zyxkad
Copy link
Collaborator Author

zyxkad commented Mar 17, 2025

The default filter count changed from 64 to infinity (max integer)

Why and shouldn't we also do that for the fluid filter then?

Because normally when player isn't providing any limit, it means no limit by intuition. Also 64 does not mean "a stack" for certain items such as tools, snowballs, etc.

@SirEndii
Copy link
Member

Good point

@SirEndii
Copy link
Member

Added it to the documentation issue IntelligenceModding/Advanced-Peripherals-Documentation#96
Maybe you want to document this

@SirEndii SirEndii merged commit d447486 into IntelligenceModding:dev/0.8-bridges Mar 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants