Skip to content

Conversation

@zyxkad
Copy link
Collaborator

@zyxkad zyxkad commented Jun 2, 2024

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
    No

@zyxkad zyxkad marked this pull request as draft June 2, 2024 15:00
@zyxkad zyxkad changed the title fix player can bypass the maximum chatbox range by setting a negative message range fix #623 fix player can bypass the maximum chatbox/playerdetector range by setting a negative range Jun 2, 2024
Copy link
Member

@SirEndii SirEndii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SirEndii
Copy link
Member

SirEndii commented Jun 2, 2024

Didn't see that this is a draft on my phone
Woops

@zyxkad
Copy link
Collaborator Author

zyxkad commented Jun 2, 2024

Yeah player detector has same issue, fixing rn

@zyxkad zyxkad marked this pull request as ready for review June 2, 2024 15:37
@zyxkad zyxkad requested a review from SirEndii June 2, 2024 15:37
Copy link
Member

@SirEndii SirEndii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zyxkad zyxkad merged commit a7f3eac into IntelligenceModding:dev/1.19.2 Jun 2, 2024
@zyxkad zyxkad linked an issue Jun 2, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chat Box allows sending of chat messages with negative range

2 participants