Skip to content

Conversation

@adarshyoga
Copy link
Contributor

@adarshyoga adarshyoga commented Apr 10, 2024

  • Have you provided a meaningful PR description?

Fix for dpnp ufunc db creation caused by addition of nin, nout and types to dpnp math functions in latest version of dpnp.

  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.065% (-0.2%) from 87.215%
when pulling c793313 on fix/dpnp_nin_issue
into 1336f76 on main.

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@diptorupd diptorupd merged commit 4708ac7 into main Apr 17, 2024
@diptorupd diptorupd deleted the fix/dpnp_nin_issue branch April 17, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants