Skip to content

Conversation

@diptorupd
Copy link
Contributor

@diptorupd diptorupd commented Mar 20, 2024

  • Have you provided a meaningful PR description?
    The PR adds versions of existing kernel unit tests to the numba_dpex.experimental.kernel. The work is a prerequisite to identify gaps before migrating features from numba_dpex.experimental to the top-level numba-dpex module.

Matrix of existing kernel unit tests

Test name Status Notes
test_atomic_op Not applicable Superseded by new AtomicRef tests in experimental module.
test_barrier TODO Experimental needs a test for group_barrier with work-group scope.
test_caching Not applicable The feature is redundant as experimental module uses Numba's function overload caching.
test_complex_array Done Renamed to test_complex_array_kernel_arg
test_dpnp_ndarray_args Done
test_dump_kernel_llvm TODO Tests for all configuration flags should be added in one place.
test_func_qualname_disambiguation Done
test_func_specialization Done #1398
test_func Done
test_invalid_kernel_args Done
test_kernel_has_return_value_error DONE. #1394
test_kernel_launch_params Not applicable Experimental does need some negative tests for call_kernel
test_kernel_specialization Done
test_math_functions Done The number of existing tests is very inadequate.
test_ndrange_exceptions TODO The test should be moved to tests/kernel_api and rewritten as a NdRange constructor test
test_print FAILS printimpl not yet added to new target context
test_private_memory_allocation Not applicable superseded by tests for kapi.PrivateArray
test_scalar_arg Done
test_sycl_usm_array_iface_interop Not applicable __SYCL_USM_ARRAY_INTERFACE__ support is slotted to be removed and for the time being only dpnp.ndarray and dpctl.tensor.usm_ndarray are valid arrya inputs. Interop is implemented indirectly using __dlpack__ conversion via dpnp/dpctl.tensor.
test_usm_ndarray_interop Done Renamed to test_usm_ndarray_args
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@diptorupd diptorupd force-pushed the tests/port_existing_kernel_tests_to_exp branch 2 times, most recently from 6b089a3 to e54e5c2 Compare March 20, 2024 03:50
@coveralls
Copy link
Collaborator

coveralls commented Mar 20, 2024

Coverage Status

coverage: 82.067% (-0.6%) from 82.668%
when pulling f65a44e on tests/port_existing_kernel_tests_to_exp
into fb33aa1 on main.

@diptorupd diptorupd requested a review from ZzEeKkAa March 20, 2024 05:14
@diptorupd diptorupd self-assigned this Mar 20, 2024
@diptorupd diptorupd force-pushed the tests/port_existing_kernel_tests_to_exp branch 3 times, most recently from 775a58f to 7fb8ddb Compare March 21, 2024 01:03
@diptorupd diptorupd force-pushed the tests/port_existing_kernel_tests_to_exp branch from 7fb8ddb to f65a44e Compare March 21, 2024 02:26
@diptorupd
Copy link
Contributor Author

@ZzEeKkAa since we have already discussed these changes together, I am going ahead and merging them.

@diptorupd diptorupd merged commit 9837719 into main Mar 21, 2024
@diptorupd diptorupd deleted the tests/port_existing_kernel_tests_to_exp branch March 21, 2024 03:42
github-actions bot added a commit that referenced this pull request Mar 21, 2024
…tests_to_exp

Tests/port existing kernel tests to experimental 9837719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants