Skip to content

Use enum values for kernel arg types if dpctl >= 0.17 #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2024
Merged

Use enum values for kernel arg types if dpctl >= 0.17 #1382

merged 1 commit into from
Mar 11, 2024

Conversation

@ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Mar 11, 2024

After IntelPython/dpctl#1585 was merged, we can use enum literals.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review March 11, 2024 13:56
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd March 11, 2024 13:56
@ZzEeKkAa ZzEeKkAa self-assigned this Mar 11, 2024
@ZzEeKkAa ZzEeKkAa force-pushed the feature/use_dpctl_enum_literal branch from 19c547b to 18f14dc Compare March 11, 2024 13:57
diptorupd
diptorupd approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to open the same PR 😄

@diptorupd diptorupd force-pushed the feature/use_dpctl_enum_literal branch from 18f14dc to e9240bd Compare March 11, 2024 20:22
@ZzEeKkAa ZzEeKkAa merged commit 2831862 into main Mar 11, 2024
@ZzEeKkAa ZzEeKkAa deleted the feature/use_dpctl_enum_literal branch March 11, 2024 23:51
github-actions bot added a commit that referenced this pull request Mar 11, 2024
@github-actions
Merge pull request #1382 from IntelPython/feature/use_dpctl_enum_literal
cb17a31 
Use enum values for kernel arg types if dpctl >= 0.17 2831862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@diptorupd diptorupd diptorupd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ZzEeKkAa ZzEeKkAa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZzEeKkAa @diptorupd