Extend indexing function tests to kernel simulator #1378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZzEeKkAa
force-pushed
the
feature/comprehensive_indexing_function_tests
branch
3 times, most recently
from
2496c08 to
dce0f34
Compare
ZzEeKkAa
force-pushed
the
feature/comprehensive_indexing_function_tests
branch
from
dce0f34 to
95eb22e
Compare
ZzEeKkAa
force-pushed
the
feature/comprehensive_indexing_function_tests
branch
2 times, most recently
from
4752af5 to
51310f9
Compare
ZzEeKkAa
force-pushed
the
feature/comprehensive_indexing_function_tests
branch
from
51310f9 to
7a8b6ca
Compare
Contributor
|
@ZzEeKkAa can you take a look at https://coveralls.io/builds/66307283/source?filename=numba_dpex%2Fkernel_api%2Findex_space_ids.py#L37. Adding some tests for 1-, 2-dimensional kernels for the linear id functions will improve coverage. |
ZzEeKkAa
force-pushed
the
feature/comprehensive_indexing_function_tests
branch
from
7a8b6ca to
632f4b8
Compare
Contributor
Author
|
@diptorupd 100% agree with you, but this is not a point of this PR. It does not introduce any new tests, just makes sure that all tests are run both on device and through simulator. |
diptorupd
approved these changes
Mar 15, 2024
github-actions bot
added a commit
that referenced
this pull request
Mar 15, 2024
…ing_function_tests Extend indexing function tests to kernel simulator 9fd6cdc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run indexing functions tests both through numba and python simulator