Skip to content

Fix/private array #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 15, 2024
Merged

Fix/private array #1377

merged 5 commits into from
Mar 15, 2024

Conversation

@ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Mar 6, 2024 •
edited
Loading

Use lower instead of overload, since we are allocating memory on the stack. Also adds optional argument fill_zeros cause previous implementation was doing so, but it is not essential and overkill for the performance.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa requested a review from diptorupd March 6, 2024 18:32
@ZzEeKkAa ZzEeKkAa self-assigned this Mar 6, 2024
diptorupd
diptorupd previously approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ZzEeKkAa ZzEeKkAa force-pushed the fix/private_array branch from 48595d4 to 66cd2c9 Compare March 8, 2024 19:01
@ZzEeKkAa ZzEeKkAa changed the base branch from main to fixup/update_dpctl_kernelargtys March 8, 2024 19:02
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd March 8, 2024 19:03
@diptorupd diptorupd force-pushed the fixup/update_dpctl_kernelargtys branch from c3e02d7 to eeb3145 Compare March 8, 2024 19:03
Base automatically changed from fixup/update_dpctl_kernelargtys to main March 9, 2024 05:17
@ZzEeKkAa ZzEeKkAa force-pushed the fix/private_array branch 7 times, most recently from 054a41b to f6d7449 Compare March 14, 2024 23:06
diptorupd
diptorupd previously approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important set of fixes that need to go in ASAP. Thank you very much!

@ZzEeKkAa ZzEeKkAa force-pushed the fix/private_array branch from f6d7449 to 0131838 Compare March 14, 2024 23:53
@ZzEeKkAa ZzEeKkAa enabled auto-merge March 14, 2024 23:53
diptorupd
diptorupd approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go!

@ZzEeKkAa ZzEeKkAa merged commit 200bf8d into main Mar 15, 2024
@ZzEeKkAa ZzEeKkAa deleted the fix/private_array branch March 15, 2024 00:21
github-actions bot added a commit that referenced this pull request Mar 15, 2024
@github-actions
Merge pull request #1377 from IntelPython/fix/private_array
0941992 
Fix/private array 200bf8d
@diptorupd diptorupd mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@diptorupd diptorupd diptorupd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ZzEeKkAa ZzEeKkAa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZzEeKkAa @diptorupd