Skip to content

Remove ^2 restriction on sum example #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2023
Merged

Remove ^2 restriction on sum example #1089

merged 1 commit into from
Jul 11, 2023

Conversation

@ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Jul 10, 2023

Just make it work with any size of array

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa requested a review from diptorupd July 10, 2023 15:44
@ZzEeKkAa ZzEeKkAa self-assigned this Jul 10, 2023
@diptorupd diptorupd force-pushed the feature/remove_power2_restriction_on_sum_example branch from e141439 to 434b516 Compare July 11, 2023 16:19
diptorupd
diptorupd approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ZzEeKkAa ZzEeKkAa merged commit 5bff8c8 into main Jul 11, 2023
@ZzEeKkAa ZzEeKkAa deleted the feature/remove_power2_restriction_on_sum_example branch July 11, 2023 18:34
github-actions bot added a commit that referenced this pull request Jul 11, 2023
@github-actions
Merge pull request #1089 from IntelPython/feature/remove_power2_restr…
fd3f056 
…iction_on_sum_example

Remove ^2 restriction on sum example 5bff8c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@diptorupd diptorupd diptorupd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ZzEeKkAa ZzEeKkAa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZzEeKkAa @diptorupd