Fix/opencl gpu exec #1074
Merged
Fix/opencl gpu exec #1074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 16, 2023 18:45
- Previously, any dpnp.ndarray objects used as an argument in a
parfor was a numba_dpex.core.types.DpnpNdArray. The commit changes
that and casts all dpnp.ndarray arguments of a parfor to
numba_dpex.core.types.USMNdArray.
The reason for the change is as follows:
Although, DpnpNdArray derives from USMNdArray the two types use
different data models. USMNdArray uses the
numba_dpex.core.datamodel.models.ArrayModel data model that defines all
CPointer type members in the GLOBAL address space. The DpnpNdArray uses
Numba's default ArrayModel that does not define pointers in any specific
address space. For OpenCL HD Graphics devices, defining a kernel
function (spir_kernel calling convention) with pointer arguments that
have no address space qualifier causes a run time crash. By casting
the argument type for parfor arguments from DpnpNdArray type to the
USMNdArray type the generated kernel always has an address space
qualifier, avoiding the issue on OpenCL HD graphics devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All parfor array arguments are now inferred as
USMNdArrayinstead ofDpnpNdArray. The change ensures that any kernel functions (LLVM IR function with aspir_kernelcalling convention) that is generated from a parfor always has an address space qualifier for every pointer argument. Defining a kernel function that has pointer arguments with no address space qualifier results in a crash for OpenCL UHD Graphics driver-based devices.No existing tests were tested with
ONEAPI_DEVICE_SELECTOR=opencl:gpu