Fixes stride calculation when unboxing a dpnp ndarray #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptorupd
force-pushed
the
fix/rambo-dpnp-impl
branch
from
4f72382 to
43920fb
Compare
Contributor
|
Tried this PR on rambo implementation in dpbench. The implementation works as expected after this fix. |
Merged
5 tasks
Contributor
Author
|
Merging based on @adarshyoga's comments. |
github-actions bot
added a commit
that referenced
this pull request
Apr 28, 2023
Fixes stride calculation when unboxing a dpnp ndarray 7e62861
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strides were computed incorrectly during unboxing a dpnp.ndarray and that was causing the issue reported in Numba-dpex implementation of Rambo fails validation #978. The PR fixes the stride computations and adds unit tests.
Fixes #978