-
Notifications
You must be signed in to change notification settings - Fork 23
Adjust Windows-only logic in __init__.py
#2553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
View rendered docs @ https://intelpython.github.io/dpnp/pull/2553/index.html |
Array API standard conformance tests for dpnp=0.19.0dev3=py313h509198e_15 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ndgrigorian
Could you please add the PR to the changelog also? |
done, it's been added |
This PR suggests small changes to Windows-specific logic in
__init__.py
hasattr(os, "add_dll_directory")
is unnecessary after platform check and is removed, andsys.platform == "win32"
is used which is more commonly seen in the ecosystem and avoids importingplatform
module