-
Notifications
You must be signed in to change notification settings - Fork 30
Accept NumPy arrays in advanced indexing #2128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_79 ran successfully. |
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_81 ran successfully. |
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_83 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndgrigorian , no more comments from me.
I run the dpnp tests with that change and they passed.
This PR proposes allowing NumPy arrays when indexing
usm_ndarray
This can be useful where attempting to use
usm_ndarray
in a library which generates indices with NumPy, and which expects to only handle devices implicitly through tensor operations (i.e., a library which can take an arbitrary tensor input, but generates indices withnumpy.random
and expects these indices to work on the input tensor)Both boolean and integer advanced indices can accept NumPy arrays with these changes
Closes #2053