Skip to content

Fix failure in knn kernel version #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2024
Merged

Fix failure in knn kernel version #333

merged 1 commit into from
Feb 7, 2024

Conversation

@adarshyoga
Copy link
Contributor

@adarshyoga adarshyoga commented Feb 7, 2024

  • Have you provided a meaningful PR description?

knn kernel implementation was failing due to a incorrect usage of array index access. The fix now uses comma-separated index access which is expected by numba-dpex

  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@adarshyoga adarshyoga requested a review from diptorupd February 7, 2024 22:40
@adarshyoga adarshyoga self-assigned this Feb 7, 2024
@diptorupd diptorupd merged commit 8972feb into main Feb 7, 2024
@diptorupd diptorupd deleted the fix/knn_failure branch February 7, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diptorupd diptorupd Awaiting requested review from diptorupd

Assignees

@adarshyoga adarshyoga

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adarshyoga @diptorupd