Skip to content

Conversation

@ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Sep 19, 2023

  • Use new way of compiling python library (CMake way, not scikit-build way, which calls deprecated functions).
  • Use latest compatible MSVC 2022 toolkit
  • Bind some packages to intel channel. Conda-forge channels packages need further investigations
  • Monkey patch msvc compiler environment set by scikit-build, so we can set it up manually (scikit-build way not allows to make precise settings, so it brings wrong environment that results in broken CI)
  • Enable python 3.11 support
  • Use GIT_DESCRIBE_NUMBER in conda build script, so newer version could be uploaded
  • Add kmeans with numba_mlir_k implementation to expected failures
  • Remove gpairs with numba_dpex_k implementation from expected failures (it looks like issue is gone with native atomic support in numba_dpex)

PR Checks:

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Sep 19, 2023
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review September 19, 2023 20:51
@ZzEeKkAa ZzEeKkAa enabled auto-merge September 19, 2023 22:09
@ZzEeKkAa ZzEeKkAa force-pushed the fix/broken_build branch 2 times, most recently from b046b05 to 43fdbec Compare September 20, 2023 00:09
Copy link

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ZzEeKkAa ZzEeKkAa merged commit ccfb262 into main Sep 20, 2023
@ZzEeKkAa ZzEeKkAa deleted the fix/broken_build branch September 20, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants