-
Notifications
You must be signed in to change notification settings - Fork 6
ENH: Bump for ITK v5.3rc04.post4 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@thewtex Update on current status:
This error occurs in the Python 3.7 build. I do not see any recent changes in @thewtex @dzenanz Have either of you seen this issue before and/or have thoughts on steps to identify the cause? Could this be related to how v5.3rc04.post4 Windows build archives were generated? |
|
I have not seen this issue before. By a quick search, it does not seem to be common. |
|
Perhaps some mismatch between MSVC versions? Or old ITK build artifacts were somehow swept up in the build? @thewtex Would you please provide specs on the Windows machine used to build Windows v5.3rc04.post4 release artifacts? |
|
@tbirdso yes, it is likely compiler versions -- I created the v5.3rc04.post4 on a system with VS 2022 -- the previous were created on VS 2019 (this is not the same as the MSVC toolchain version, but likely an earlier version). @tbirdso could you please try |
Resolves compiler mismatch issue where ITK v5.3rc04.post4 build archives were built with VS22 compiler
7a7cf71 to
6a26dd5
Compare
Addresses Windows cxx build warnings due to MSVC discovery issues that were fixed in CMake v3.21.3. The closest available tag for the `lukka/get-cmake` action is v3.22.2, which also updates `ninja` to 1.10.2. https://gitlab.kitware.com/cmake/cmake/-/merge_requests/6497 https://github.com/lukka/get-cmake/releases/tag/v3.22.2
|
ITKSplitComponents is green: https://github.com/InsightSoftwareConsortium/ITKSplitComponents/actions/runs/3492450754/jobs/5846243542 Proceeding with merge |
Updates cookiecutter CI workflow to rely on ITKRemoteModuleBuildTestPackageAction reusable workflows for easier maintenance. Updates ITK reference to v5.3rc04.post4 and applies version updates from reusable workflow. See InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#9
Updates cookiecutter CI workflow to rely on ITKRemoteModuleBuildTestPackageAction reusable workflows for easier maintenance. Updates ITK reference to v5.3rc04.post4 and applies version updates from reusable workflow. See InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#9
Pending successful ITKSplitComponents test workflow run
https://github.com/InsightSoftwareConsortium/ITKSplitComponents/actions/runs/3472832027