Skip to content

Conversation

@tbirdso
Copy link
Collaborator

@tbirdso tbirdso commented Nov 15, 2022

@tbirdso tbirdso requested review from dzenanz and thewtex November 15, 2022 17:43
@tbirdso
Copy link
Collaborator Author

tbirdso commented Nov 16, 2022

@thewtex Update on current status:

  • Linux build archives for v5.3rc04.post4 do not contain Python 3.11 sources and Linux Python 3.11 wheels are not present on PyPI (https://pypi.org/project/itk/5.3rc4.post4/#files) for the release. I have identified the issue in ITKPythonPackage, am rebuilding archives, and will submit a patch to ITKPythonPackage shortly.
  • I am concerned by Windows failures in ITKSplitComponents:
ITKCommon-5.3.lib(itkSingleton.cxx.obj) : error LNK2019: unresolved external symbol __std_init_once_link_alternate_names_and_abort referenced in function "void __cdecl std::call_once<class <lambda_765cdde47a138f6f7443124c5cc7592a> >(struct std::once_flag &,class <lambda_765cdde47a138f6f7443124c5cc7592a> &&)" (??$call_once@V<lambda_765cdde47a138f6f7443124c5cc7592a>@@$$V@std@@YAXAEAUonce_flag@0@$$QEAV<lambda_765cdde47a138f6f7443124c5cc7592a>@@@Z)
ITKCommon-5.3.lib(itkImageSourceCommon.cxx.obj) : error LNK2001: unresolved external symbol __std_init_once_link_alternate_names_and_abort
ITKCommon-5.3.lib(itkThreadPool.cxx.obj) : error LNK2001: unresolved external symbol __std_init_once_link_alternate_names_and_abort
C:\P\IPP\ITK-win_37-x64\Wrapping\Generators\Python\itk\_SplitComponentsPython.pyd : fatal error LNK1120: 1 unresolved externals

This error occurs in the Python 3.7 build. I do not see any recent changes in itkThreadPool, and from the error message it seems like this is an STL compiler issue. There is some discussion around MSVC static library changes from earlier this year in https://developercommunity.visualstudio.com/t/__imp___std_init_once_complete-unresolve/1684365, though it sounds like those were resolved.

@thewtex @dzenanz Have either of you seen this issue before and/or have thoughts on steps to identify the cause? Could this be related to how v5.3rc04.post4 Windows build archives were generated?

@dzenanz
Copy link
Member

dzenanz commented Nov 16, 2022

I have not seen this issue before. By a quick search, it does not seem to be common.

@tbirdso
Copy link
Collaborator Author

tbirdso commented Nov 16, 2022

Perhaps some mismatch between MSVC versions? Or old ITK build artifacts were somehow swept up in the build?

@thewtex Would you please provide specs on the Windows machine used to build Windows v5.3rc04.post4 release artifacts?

@thewtex
Copy link
Member

thewtex commented Nov 16, 2022

@tbirdso yes, it is likely compiler versions -- I created the v5.3rc04.post4 on a system with VS 2022 -- the previous were created on VS 2019 (this is not the same as the MSVC toolchain version, but likely an earlier version). @tbirdso could you please try windows-2022 actions runner: https://github.com/actions/runner-images/blob/main/images/win/Windows2022-Readme.md

Resolves compiler mismatch issue where ITK v5.3rc04.post4 build archives
were built with VS22 compiler
Addresses Windows cxx build warnings due to MSVC discovery issues that
were fixed in CMake v3.21.3. The closest available tag for the
`lukka/get-cmake` action is v3.22.2, which also updates `ninja` to
1.10.2.

https://gitlab.kitware.com/cmake/cmake/-/merge_requests/6497

https://github.com/lukka/get-cmake/releases/tag/v3.22.2
@tbirdso tbirdso marked this pull request as ready for review November 18, 2022 01:15
@tbirdso
Copy link
Collaborator Author

tbirdso commented Nov 18, 2022

@tbirdso tbirdso merged commit 29ad46f into main Nov 18, 2022
tbirdso added a commit to InsightSoftwareConsortium/ITKModuleTemplate that referenced this pull request Nov 18, 2022
Updates cookiecutter CI workflow to rely on
ITKRemoteModuleBuildTestPackageAction reusable workflows for easier
maintenance.

Updates ITK reference to v5.3rc04.post4 and applies version updates
from reusable workflow.

See InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#9
@thewtex thewtex deleted the bump-itk branch November 18, 2022 16:08
jhlegarreta pushed a commit to jhlegarreta/ITKModuleTemplate that referenced this pull request Jul 2, 2024
Updates cookiecutter CI workflow to rely on
ITKRemoteModuleBuildTestPackageAction reusable workflows for easier
maintenance.

Updates ITK reference to v5.3rc04.post4 and applies version updates
from reusable workflow.

See InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants