Skip to content

Conversation

@tbirdso
Copy link
Collaborator

@tbirdso tbirdso commented Aug 23, 2022

Migrate ITK C++ and Python Github CI procedures into reusable workflows that can be called and run by ITK external modules.

Partially addresses InsightSoftwareConsortium/ITKModuleTemplate#131.

Caveats:

  1. Reusable workflows are only designed and tested for simple remote modules with no extra build steps.
  2. Passing custom CMake arguments to a remote module build is feasible but untested. Custom CMake arguments should be considered not supported for this first iteration.
  3. Remote modules depending on other remote modules or libraries are not currently supported. Modules with extra dependencies are responsible for implementing their own CI pipelines. The workflows here have been forked from ITKModuleTemplate and can in turn be forked as a starting point for a custom pipeline in a remote module repository.

@tbirdso tbirdso force-pushed the test-reusable-workflow branch 3 times, most recently from 67c5ebf to 42b706c Compare August 23, 2022 15:43
@tbirdso tbirdso force-pushed the test-reusable-workflow branch 4 times, most recently from d4104b0 to 885a922 Compare October 7, 2022 20:28
@tbirdso tbirdso changed the title WIP: Test reusable workflow with multiple runners ENH: Add ITK C++ and Python CI Reusable Workflows Oct 7, 2022
@tbirdso tbirdso requested review from dzenanz and thewtex October 7, 2022 20:29
@tbirdso
Copy link
Collaborator Author

tbirdso commented Oct 7, 2022

Observed passing CI on ITKSplitComponents: https://github.com/InsightSoftwareConsortium/ITKSplitComponents/actions/runs/3207298168/jobs/5242405654

Changes have been squashed. Ready for review.

EDIT: It appears I introduced a yml error somewhere during my squash... will continue to investigate.

EDIT2: Fixed and squashed a missing steps: line mistakenly removed with testing comments. Pipeline is now parsed correctly again.

@tbirdso tbirdso force-pushed the test-reusable-workflow branch from b32f2d2 to d5f3ab7 Compare October 10, 2022 12:37
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. The big test is whether it works 😄

@tbirdso
Copy link
Collaborator Author

tbirdso commented Oct 10, 2022

Thanks @dzenanz . Note that development tests in ITKSplitComponents using these workflows are passing: InsightSoftwareConsortium/ITKSplitComponents#63

@tbirdso
Copy link
Collaborator Author

tbirdso commented Oct 10, 2022

Going ahead and merging so that reusable workflows can be tagged and referenced in remote module CI. Additional feedback can be added as discussions here or in the issue tracker.

@tbirdso tbirdso merged commit 68f1414 into main Oct 10, 2022
@thewtex thewtex deleted the test-reusable-workflow branch October 17, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants