chore: adopt golangci-lint v2 #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InftyAI-Agent
added
needs-triage
Member
|
I'll more inclined to adopt v2, I'll update the workflow project as well. |
Member
|
Hi @rudeigerc could you update the golang workflow version to v0.1.21? |
Signed-off-by: rudeigerc <[email protected]>
rudeigerc
force-pushed
the
chore/golangci-lint-v2
branch
from
406b14e to
0470259
Compare
Member
Author
|
@kerthcet Updated :) |
Member
|
Everything seems working as expected, thanks! |
InftyAI-Agent
added
lgtm
Member
|
/kind cleanup |
InftyAI-Agent
added
cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This pull request bumps
golangci-lintversion to v2. The config has been migrated viagolangci-lint migratesuggested in https://golangci-lint.run/product/migration-guide/.For developers, they may have to remove the binary in
binfirst if it already exists before runningmake lint.Which issue(s) this PR fixes
Fixes #462
Special notes for your reviewer
https://github.com/kerthcet/github-workflow-as-kube/blob/61f946b54583a4cd632ce968b95aafc82d5aab73/.github/workflows/workflow-golang-ci.yaml#L12
The
golangci-lintversion defined in kerthcet/github-workflow-as-kube may also need to be updated. However, I am unsure whether this would affect other repositories. /cc @kerthcetDoes this PR introduce a user-facing change?