TASK: fixed npmScopeArg rewriting, exclude all special characters. #47
+43
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly dash-cased name allowed
Inkdpixels
requested changes
Dec 12, 2017
| '´' | ||
| ]; | ||
| specialChars.forEach(character => { | ||
| expect(instance.safelyCreateNpmScopeArg(`${character}foo-bar`)).toBe( |
There was a problem hiding this comment.
You could simplify this test a bit by using the specialChars with a join(''), that way you can remove the forEach iteration, the test is a bit leaner and you would also cover that the characters should be replaced globally and not just once - Aside from that little thing, awesome job! 💯
Inkdpixels
approved these changes
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only dash-cased names allowed