Skip to content

Conversation

@johnhaddon
Copy link
Member

This get IECoreImage building and the tests passing with OpenImageIO 3, while maintaining compatibility with OpenImageIO 2.

johnhaddon added 2 commits May 9, 2025 09:47
The type aliases nested in the TypeDesc class have been removed. Both OIIO 2 and 3 have namespace-level equivalents, so the new code will compile with both.
@johnhaddon johnhaddon requested a review from murraystevenson May 9, 2025 09:26
@johnhaddon johnhaddon self-assigned this May 9, 2025
johnhaddon added 2 commits May 9, 2025 10:46
There are two changes that affect us :

- `ImageCache::create()` now returns a `shared_ptr`.
- `ImageCache::imagespec()` completely ignores the `miplevel` parameter, and we have to use `get_cache_dimensions()` instead.
@murraystevenson murraystevenson merged commit ee32580 into ImageEngine:RB-10.5 May 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants