IECoreUSD::PointInstancerAlgo : Support inactive / invisible ids #1437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
reviewed
Oct 9, 2024
Member
johnhaddon
left a comment
johnhaddon
left a comment
There was a problem hiding this comment.
Thanks Daniel - couple of small comments inline. We also need to target this to RB-10.5.
danieldresser-ie
force-pushed
the
instancerInvis
branch
from
995de90 to
30ba213
Compare
Contributor
Author
|
Addressed comments, squashed, rebased to RB-10.5 |
We're not using the result anywhere. I assume this was an early attempt at ignoring unauthored values, eventually replaced by the code below.
Member
|
Thanks for the updates Daniel, and sorry for the delay in getting back to this. Merging now, but I should point out that I've added a commit which removes some code I think is redundant - tell me if it's not! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty naive implementation of loading inactiveIds and invisibleIds as prim vars, but everything seems to work.
Haven't yet used this to recreate the correct behaviour in Gaffer, but all the relevant data seems to be coming through.