ToMayaMeshConverter : No longer set normals #1386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when converting from a Cortex object to a Maya Mesh, we set the normals anytime the normals are stored in the scc. Setting the normals explicitly implies these are static values and so Maya locks them rather than computing them on the fly. Locked normales are undesirable in many parts of the Pipeline, especially for deforming geometry as not recomputing them leads to unexpected results, e.g. wrong tangents or incorrect shader computations. This change removes the normal transfer from the scc to the Maya geometry and instead we rely on Maya to compute them.
Update test to exclude checking normals are equal since now we rely on normals being computed by Maya which createBox does not do
Add to normals test a check that normals are unlocked after converting from a cortex object
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when converting from a Cortex object to a Maya Mesh we set the normals anytime the normals were stored on the scc but by doing so we imply these are static values and so Maya locks them. Locked normals are undesirable in many parts of the Pipeline especially when deforming meshes as forcing the normal to stay the same causes unexpected results. Unlocked normals make more sense in most cases as they are computed values. This change willl stop setting normals so they are unlocked and instead rely on Maya to compute them.
Breaking Changes
Fixes
Related Issues
Checklist