Skip to content

Conversation

melanger
Copy link
Contributor

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
    Yes, although there is a related issue Allow definition of metadata URL for SAML plugins #280
  • Have you added an explanation of what problem you are trying to solve with this PR?
    Unclear README.
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
    No tests needed.
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?
    Not needed.

To demonstrate that it has to be a top level option, not nested inside `idp_config`
To demonstrate that it has to be a top level option, not nested inside `sp_config`
@melanger melanger changed the title Patch 1 Include entityid_endpoint in the example SAML2 configurations Sep 29, 2020
@c00kiemon5ter c00kiemon5ter merged commit 51e2556 into IdentityPython:master Sep 29, 2020
@c00kiemon5ter
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants